[Bug 41448] Installing unit tests

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41448

--- Comment #6 from Marco Barisione <marco.barisione at collabora.co.uk> 2011-10-19 03:39:29 PDT ---
+++ b/tests/twisted/tools/run-gabble.sh.in
@@ -2,7 +2,7 @@

 export G_DEBUG=fatal-warnings,fatal-criticals
 export GABBLE_TIMING=1
-export GABBLE_PLUGIN_DIR="@libdir@/telepathy/gabble-0"
+export
GABBLE_PLUGIN_DIR="@abs_top_tests_installdir@/plugins:@libdir@/telepathy/gabble-0"

Are you using the same run-gabble.sh for both installed and uninstalled tests?
This is a bit weird, it could load the wrong plugin.
Also, I think it's @libexecdir@ and not @libdir@ (but I'm not 100% sure).

+non_installable_plugins = \
+    test.la
+

Another name could be better considering that sometimes you install it :)

 noinst_LTLIBRARIES = \
-    test.la
+    $(NULL)
+

Why leaving there an empty list? Just don't define noinst_LTLIBRARIES.

+export GABBLE_PLUGIN_DIR="@libdir@/telepathy/gabble-0"

@libexecdir@?

--- a/src/plugin-loader.c
+++ b/src/plugin-loader.c

Is it neded if you use a single run-gabble.sh?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.