[Bug 41448] Installing unit tests

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41448

--- Comment #8 from Alban Crequy <alban.crequy at collabora.co.uk> 2011-10-19 04:26:22 PDT ---
(In reply to comment #6)
> +++ b/tests/twisted/tools/run-gabble.sh.in
> @@ -2,7 +2,7 @@
> 
>  export G_DEBUG=fatal-warnings,fatal-criticals
>  export GABBLE_TIMING=1
> -export GABBLE_PLUGIN_DIR="@libdir@/telepathy/gabble-0"
> +export
> GABBLE_PLUGIN_DIR="@abs_top_tests_installdir@/plugins:@libdir@/telepathy/gabble-0"
> 
> Are you using the same run-gabble.sh for both installed and uninstalled tests?

No, run-gabble.sh is only used for the installed tests. The uninstalled tests
still use exec-with-log.sh.

> This is a bit weird, it could load the wrong plugin.

GABBLE_PLUGIN_DIR for the installed tests needs 2 paths:
- @abs_top_tests_installdir@/plugins: for the "test" plugin (this plugin is not
installed in regular installations)
- @libdir@/telepathy/gabble-0: for the "gateway" plugin

> Also, I think it's @libexecdir@ and not @libdir@ (but I'm not 100% sure).

What Jonny said :)

> +non_installable_plugins = \
> +    test.la
> +
> 
> Another name could be better considering that sometimes you install it :)

Right. "test_only_plugins"?

>  noinst_LTLIBRARIES = \
> -    test.la
> +    $(NULL)
> +
> 
> Why leaving there an empty list? Just don't define noinst_LTLIBRARIES.

If it is defined in one of the "if" branches, it must be defined in the other
"if" branch. Otherwise, autoconf complains when something is added with the
"+=" operator.

> +export GABBLE_PLUGIN_DIR="@libdir@/telepathy/gabble-0"
> 
> @libexecdir@?

What Jonny said :)

> --- a/src/plugin-loader.c
> +++ b/src/plugin-loader.c
> 
> Is it needed if you use a single run-gabble.sh?

Yes because I specified 2 directories when running the installed tests.
run-gabble.sh is only used for the installed tests.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.