[Bug 42049] base-contact-list doesn't implement TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42049

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-10-20 06:12:20 PDT ---
Comment on attachment 52579
  --> https://bugs.freedesktop.org/attachment.cgi?id=52579
base-contact-list: implement
TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED

Review of attachment 52579:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=42049&attachment=52579)
-----------------------------------------------------------------

Looks reasonable except for a copy-paste error.

::: telepathy-glib/base-contact-list.c
@@ +6139,5 @@
>            tp_base_contact_list_fill_groups_contact_attributes);
>      }
> +
> +  if (g_type_is_a (type, TP_TYPE_SVC_CONNECTION_INTERFACE_CONTACT_BLOCKING)
> +      && TP_IS_CONTACT_GROUP_LIST (self))

Why TP_IS_CONTACT_GROUP_LIST? I don't think blocking should depend on groups.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.