[Bug 42281] Doesn't advertise ContactBlocking when supported

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42281

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-10-26 07:01:18 PDT ---
Comment on attachment 52797
  --> https://bugs.freedesktop.org/attachment.cgi?id=52797
Advertise ContactBlocking if supported

Review of attachment 52797:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=42281&attachment=52797)
-----------------------------------------------------------------

Functionally, looks fine.

::: src/connection.c
@@ +2819,5 @@
> +    {
> +       const gchar *ifaces[] =
> +         { TP_IFACE_CONNECTION_INTERFACE_CONTACT_BLOCKING, NULL };
> +
> +      tp_base_connection_add_interfaces ((TpBaseConnection *) conn, ifaces);

Something is funky with the indentation here. The declaration of 'ifaces' is
one space further in than the function call.

::: tests/twisted/roster/test-google-roster.py
@@ +296,5 @@
>          )
>  
> +    assertContains(cs.CONN_IFACE_CONTACT_BLOCKING,
> +                  conn.Get(cs.CONN, "Interfaces",
> +                           dbus_interface=cs.PROPERTIES_IFACE))

conn.Properties.Get(cs.CONN, "Interfaces")

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.