[Bug 41448] Installing unit tests

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41448

Alban Crequy <alban.crequy at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://cgit.collabora.com/g |http://cgit.collabora.com/g
                   |it/user/alban/telepathy-gab |it/user/alban/telepathy-gab
                   |ble.git/log/?h=tests5       |ble.git/log/?h=tests6

--- Comment #16 from Alban Crequy <alban.crequy at collabora.co.uk> 2011-10-28 08:34:25 PDT ---
(In reply to comment #15)
> It seems a bit unfortunate that a separate dbus-daemon and Gabble are spawned
> for every individual installed test one runs … but oh well!
> 
> I assume Gabble with this branch passes `make distcheck`?

Hum... It didn't but I fixed it now!

> Here are some nitpicks:
> 
> +        Test files installation.....:  ${installed_tests}
> 
> “Install unit tests”

fixed

> +gabble-C-tests.list:
> +    echo $(tests_list) > $@
> 
> If you use this:
> 
>   $(AM_V_GEN)echo $(tests_list) > $@
> 
> then it will show up as
> 
>   GEN     gabble-C-tests.list
> 
> in the output of make V=0.

fixed

> -  const gchar *directory_name = g_getenv ("GABBLE_PLUGIN_DIR");
> +  const gchar *directories_name = g_getenv ("GABBLE_PLUGIN_DIR");
> 
> 'directory_names' would be better English.

fixed

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.