[Bug 40734] Delay returning from SetSubject until the server acks or nacks the change

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 28 18:56:15 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=40734

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Implement                   |Delay returning from
                   |Channel.Interface.Subject   |SetSubject until the server
                   |                            |acks or nacks the change

--- Comment #8 from Will Thompson <will.thompson at collabora.co.uk> 2011-10-28 09:56:15 PDT ---
(In reply to comment #2)
> > static void _network_member_left(IdleMUCChannel *chan, TpHandle leaver, TpHandle actor, const gchar *message, TpChannelGroupChangeReason reason) {
> > -        IdleMUCChannelPrivate *priv = IDLE_MUC_CHANNEL_GET_PRIVATE(chan);
> > +        TpBaseChannel *base = TP_BASE_CHANNEL (chan);
> > +TpBaseConnection *base_conn = tp_base_channel_get_connection (base);
> 
> Indentation needed.

Thanks, fixed.

> Otherwise looks good.

I've merged my branch to master, but I'll retitle the bug for the
returning-later issue.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list