[Bug 42233] Telepathy-glib uses deprecated GLib API (breaks build from jhbuild)

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Oct 28 19:44:28 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=42233

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2011-10-28 10:44:28 PDT ---
Comment on attachment 52754
  --> https://bugs.freedesktop.org/attachment.cgi?id=52754
Replace deprecated g_unix_socket_* functions

Review of attachment 52754:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=42233&attachment=52754)
-----------------------------------------------------------------

Looks good except for a style point.

::: telepathy-glib/gnio-util.c
@@ +213,2 @@
>                  type = TP_SOCKET_ADDRESS_TYPE_ABSTRACT_UNIX;
> +              }

If you're going to add {} around one branch of the conditional, you should add
them around the other, too.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list