[Bug 40518] Contacts appear in local pending and then immediately disappear again on GTalk

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40518

--- Comment #6 from Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> 2011-10-31 08:15:21 PDT ---
(In reply to comment #5)
> -    # We add Alice
> +    # Alice asks to subscribes to us
> 
> This should be a separate patch.
> 
> -    self_handle = conn.GetSelfHandle()
> As should this.

OK.
This test has been introduced by Marco, so I guess that it means it will be
committed as two separate patch sets, one from Marco and the second from me
atop Marco's work.



> +    iq = make_set_roster_iq(stream, 'test at localhost/Resource', contact,
> +            "none", False)
> +    stream.send(iq)
> 
> You should move the comment
> 
>     # Now we send the spurious roster update with subscribe="none" and verify
>     # that nothing happens in reaction to that
> 
> up to before you test this new case.
> 
> (In reply to comment #4)
> > What I seems odd is the ContactsChanged with NO -> REMOVED_REMOTELY (1->2),
> > while the handle should've been in ASK state according to the last signal.
> > Since Marco's fix is based on the ASK state, it might be it.
> 
> I don't think it's changing from No to Removed_Remotely.
> 
> 
> +    q.expect('dbus-signal', signal='ContactsChanged',
> +            args=[{handle: (cs.SUBSCRIPTION_STATE_NO,
> +                cs.SUBSCRIPTION_STATE_REMOVED_REMOTELY, '')}, []])
> 
> The first two fields of the tuple mean:
> 
> • We are not subscribing to the contact's presence;
> • The contact removed their request to see our presence.
> 
> The previous state change, in response to their subscription request, was:
> 
>     q.expect('dbus-signal', signal='ContactsChanged',
>             args=[{handle: (cs.SUBSCRIPTION_STATE_NO,
>                 cs.SUBSCRIPTION_STATE_ASK, '')}, []])
> 
> which means:
> 
> • We are not subscribing to the contact's presence;
> • The contact has asked to see our presence.

Right, the first field is the sate of "subscribe" and the second of "publish"

http://telepathy.freedesktop.org/spec/Connection_Interface_Contact_List.html#Struct:Contact_Subscriptions

it does not represent a transition. my bad.

> So I think this test looks right.

It the test looks correct, the fact that it fails means that we need to look a
way to fix it in gabble.

I can look at it, if Marco agrees (he's quite busy AFAIK).

> -if test $sleep != 0; then
> +if [ "$sleep" -ne 0 ]; then
> 
> What's this for?

The shell complained and I had to fix to be able to run the test.

It should be in a different commit as well, if the patch is OK.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.