[Bug 41801] High level API for ContactBlocking

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41801

--- Comment #4 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-10-31 08:21:10 PDT ---
(In reply to comment #2)
> +    g_return_if_fail (_tp_contacts_to_handles (self, n_contacts, contacts, \
> +        &handles)); \
> 
> You can't do this: g_return_if_fail can be compiled away to nothing.

Oh good point. Fixed; I'll fix existing code as well.

> Why does the first patch define a macro (contact_blocking_generic_async) which
> it doesn't actually use?

removed.

> What does "contact-list-clt.c" mean?

client. We already have contact-list.c testing TpBaseConnection and I prefered
to creater a new file testing the client bits as it was already pretty big.
I can rename to contact-list-client if you prefer.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.