[Bug 41790] Make libnice dependency optional

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Oct 31 17:51:05 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=41790

--- Comment #3 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-10-31 09:51:05 PDT ---
(In reply to comment #2)
> +    AC_SUBST(NICE_CFLAGS)
> +    AC_SUBST(NICE_LIBS)
> +else
> +    NICE_CFLAGS=
> +    NICE_LIBS=
> +fi
> 
> If you're not AC_SUBSTing the empty variables, can't you just leave the else
> clause out entirely?
Actually I should AC_SUBST them every time, will fix this

> I don't really like how this patch litters quite so many ifdefs around, even
> down to changing the number of arguments to gabble_file_transfer_channel_new()…
Tbh, I don't like it either, but I don't see how it could be any better,
suggestions?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list