[Bug 32611] Implement gabble Room interface updates

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 6 19:26:20 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=32611

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |
                   |?p=user/jonny/telepathy-gab |
                   |ble.git;a=shortlog;h=refs/h |
                   |eads/room                   |
         Depends on|                            |23151
             Blocks|23151                       |

--- Comment #15 from Will Thompson <will.thompson at collabora.co.uk> 2011-09-06 10:26:18 PDT ---
Okay, so…

I have a crapload of patches on top of Jonny's branch, at
http://cgit.collabora.com/git/user/wjt/telepathy-gabble-wjt.git/log/?h=moar-room.
It branches from Jonny's at the branch named 'hi-jonny': I've reviewed
everything before that.

It depends on a branch of telepathy-glib, which I have split into pieces to
make it easier to review.

First,
http://cgit.collabora.com/git/user/wjt/telepathy-glib.git/log/?h=dbus-properties-mixin-stuff
adds support for emitting PropertiesChanged to TpDBusPropertiesMixin.

Then the moar-room branch of Gabble depends on that (plus a snapshot of the
spec from bug 23151). Along the way I write a prototype for TpBaseRoomConfig in
Gabble. I then move that to tp-glib:
http://cgit.collabora.com/git/user/wjt/telepathy-glib.git/log/?h=bye-bye-properties

I'm sorry the Gabble branch is so ridiculously big. Compared to Jonny's branch:

 19 files changed, 1344 insertions(+), 1741 deletions(-)

And compared to master:

 extensions/Channel_Interface_Room.xml    |  373 -------
 extensions/Makefile.am                   |    2 +-
 extensions/all.xml                       |    1 -
 src/Makefile.am                          |    3 +
 src/muc-channel.c                        | 1705 +++++++++++++-----------------
 src/muc-channel.h                        |   29 +-
 src/muc-factory.c                        |   38 +-
 src/room-config.c                        |  101 ++
 src/room-config.h                        |   61 ++
 src/server-tls-manager.c                 |    2 -
 tests/twisted/Makefile.am                |    2 +-
 tests/twisted/constants.py               |   12 +-
 tests/twisted/muc/room-config.py         |  388 +++++++
 tests/twisted/muc/room.py                |   40 +-
 tests/twisted/muc/subject.py             |  147 ++-
 tests/twisted/muc/test-muc-properties.py |  102 --
 tests/twisted/muc/test-muc.py            |   38 +-
 tests/twisted/mucutil.py                 |    6 +-
 tests/twisted/ns.py                      |    1 +
 19 files changed, 1453 insertions(+), 1598 deletions(-)

It removes all support for Telepathy.Properties from MucChannel. Pretty much
the future!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list