[Bug 40681] TpConnection should prepare features on its self contact

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Sep 7 22:53:06 CEST 2011


--- Comment #3 from Xavier Claessens <xclaesse at gmail.com> 2011-09-07 13:53:06 PDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > It is a bit more complex than expected because we have to make sure the self
> > contact is fetched late in connection's introspection so it has attribute
> > ifaces.
> Actually, you're allowed to blindly pass all the interfaces you want to
> GetContactAttributes() these days—but I guess tp-glib client side hasn't been
> updated to take advantage of that. (Or am I misunderstanding?)

That would simplify stuff I guess. But atm in contacts_bind_to_signals() it
ignore features wanted that does not have known interface.

Actually this make me realize a possible race with contact-list feature: if I
get ContactListState going to SUCCESS before the TpConnection got its contact
attribute interfaces, it won't prepare all features on roster contacts.

> +  /* FIXME: We should use tp_simple_client_factory_dup_contact(), but that
> would
> This function doesn't exist. (It is also mentioned in an existing comment in
> contact.c; perhaps you'd like to fix that at the same time.)


> The branch looks fine, functionally speaking: perhaps a test case would be
> nice?


Branch updated

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list