[Bug 34840] Doesn't strip newlines from kick/part/ … messages

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Sep 9 10:54:26 CEST 2011


--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2011-09-09 01:54:25 PDT ---
Created an attachment (id=50995)
 View: https://bugs.freedesktop.org/attachment.cgi?id=50995
 Review: https://bugs.freedesktop.org/review?bug=34840&attachment=50995

Connection: replace \r and \n with spaces

If a message gets as far as _send_with_priority and contains \r or \n,
it's almost certainly not what the user anticipated. For instance,
before this fix, calling

    RemoveMembers([self_handle], "bye\r\nJOIN #telepathy")

would cause the user to leave the channel with the message "bye", and
then accidentally join #telepathy.

Rather than trying to strip out \r and \n everywhere, this patch just
replaces them with spaces just before sending.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list