[Bug 32611] Implement gabble Room interface updates

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32611

--- Comment #21 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-09-16 03:24:21 PDT ---
Your extra patches look fine.

(In reply to comment #20)
> (In reply to comment #19)
> > I'm not sure this UpdateConfiguration API is great for protocols where setting
> > property can succeed and another fail in the same operation. This seems to
> > think all will succeed or all will fail. I don't have this protocol or even a
> > solution in mind for this.
> 
> That's true. IRC has this issue, for instance. FWIW the old API had the same
> issue. :) What else should we do? Only allow changing one field at a time?
> Represent partial success with a successful return with a dictionary of what
> failed? (I really hate APIs like the latter.)
> 
> With the status quo, if some, but not all, changes were applied, the properties
> which did get changed should have their values updated in any case.
> Well-behaved CMs could prioritise more crucial settings over less crucial ones:
> so like, update the password before disabling invite-only, or whatever.

I'm not sure what the solution should be. Perhaps we should talk about this at
some point.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.