[Bug 38568] Add an XMPP console

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38568

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-09-21 02:23:59 PDT ---
(In reply to comment #3)
> "Le mieux est l'ennemi du bien", let's start with that (I guess we are not
> commiting any kind of API stability for such sidecar right ?).
> 
> +static void
> +gabble_console_plugin_init (GabbleConsolePlugin *self)
> +{
> +  DEBUG ("hi");
> 
> We can just remove that.

Done.
> 
> +  iface->name = "Console registration plugin";
> XMPP console?

Changed.

> +      g_simple_async_result_set_from_error (simple, error);
> +      g_error_free (error);
> 
> If your GLib is cool enough you could use g_simple_async_result_take_error().

We officially don't depend on a cool enough GLib.

I'll merge the UI into this branch shortly.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.