[Bug 38978] NetworkManager / ConnMan support

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Sep 23 17:50:58 CEST 2011


--- Comment #13 from Will Thompson <will.thompson at collabora.co.uk> 2011-09-23 08:50:58 PDT ---
(In reply to comment #11)
> Looks great; you owned with those tests!

I aim to please.

> + * Copyright (C) 2009 Collabora Ltd.
> should be updated

Done. I'll squash this back. I updated the .h but forgot to update the .c.

> Would be good to open a nm-glib bug report as in a perfect world MC shouldn't
> do blocking calls.

I guess the counter-argument will be that one blocking call during
initialization is not bad enough to warrant async-ifying the entire API. This
is an unusual case. I actually tried making the fake NM and ConnMan services
run in a separate process from the test case, which would (I think) be better
in any case, but that fails due to heinous crimes committed by the MC test

> McdKludgeTransport: why "kludge"?

For want of a better name, really.

> +    GList *one;
> I'd add a comment explaining what's this; it's not that clear to me.

I have done so—I've renamed the variable too.

>   return "i love the internet";
> rly? :)


Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the telepathy-bugs mailing list