[Bug 40695] Expose more caps code to plugins

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 27 16:20:36 CEST 2011


--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-09-27 07:20:35 PDT ---
(In reply to comment #3)
> (In reply to comment #1)
> > +  /* just borrow the ref, data_forms doesn't have a free func */
> > +  while (g_hash_table_iter_next (&iter, &k, &v))
> > +    tp_g_ptr_array_extend (data_forms, v);
> > 
> > At this point (or possibly sooner if we can), we should verify that all forms
> > have a FORM_TYPE field, and that they are all distinct. From XEP-0115 §5.4
> > <http://xmpp.org/extensions/xep-0115.html#ver-proc>:
> [...]
> > (Hmm interesting, do we obey clause 5?) But we should warn if a plugin (or
> > indeed Gabble itself) is causing us to generate ill-formed disco responses per
> > clause 4.
> What do you reckon we should do if a client is represented and gives some bad
> data forms, or perhaps only one bad data form, or a duplicate form type? Do we
> ignore *all* data forms from this client? Do we ignore all caps completely? I
> can't decide what to do here.

I would go with: warn and drop the bad/duplicated forms, ideally (in the
duplicated case) saying which other channel manager provided the same form in
the warning. Even more ideally, maybe we could prefer to use forms from channel
managers within Gabble… but broadly speaking I think just warning and dropping
them will work out okay.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list