[Bug 28370] Should watch UPower AboutToSleep signal

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Sep 28 18:59:51 CEST 2011


--- Comment #6 from Will Thompson <will.thompson at collabora.co.uk> 2011-09-28 09:59:51 PDT ---
(In reply to comment #5)
> Maybe we should factor out this code:
> +  g_signal_emit (self, signals[STATE_CHANGE], 0,
> +      priv->connected && priv->awake);
> Especially, you check if priv->awake actually changed before firing this
> signal, but if priv->connected is still FALSE, you actually didn't change the
> state.
> The opposite is probably true as well: connected changing but awake being

Right you are. I've pushed a patch that addresses this.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list