[Bug 41356] No method to retrieve available message types [patch]

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Sep 30 17:05:13 CEST 2011


--- Comment #1 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-09-30 08:05:13 PDT ---
Hey David, here goes some comments regarding the patch. Just some minor tweaks
here and there

+/** Returns true if the provided message type is supported.
+  *
+  */
+bool TextChannel::supportsMessageType(ChannelTextMessageType messageType)

Should become something like
+ * Return whether the provided message type is supported.
+ * 
+ * This method requires TextChannel::FeatureMessageCapabilities to be ready.
+ *
+ * \param messageType The message type to check.
+ * \return \c true if supported, \c false otherwise
+ */
+bool TextChannel::supportsMessageType(ChannelTextMessageType messageType)

Please also add a check for FeatureCapabilities being ready there and warn in
case it's not and the method was called.

Also I would like to have a public QSet<ChannelTextMessageType> (or maybe
QList?) TextChannel::supportedMessageTypes() const. Note that the method should
not return a UIntList. It should also check for FeatureCapabilities and be
properly documented.

Also rename the internal private variable holding the supported message types
to something like "supportedMessageTypes" instead of "channelTextMessageTypes"

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list