[Bug 45554] various modules' GAsyncResults cannot safely be reffed and kept around

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45554

--- Comment #14 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-04-11 09:07:35 PDT ---
Comment on attachment 59796
  --> https://bugs.freedesktop.org/attachment.cgi?id=59796
[1/2] channel-contacts: merge contacts_queue_item_new into  contacts_queue_item

Review of attachment 59796:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=45554&attachment=59796)
-----------------------------------------------------------------

Looks fine.

::: telepathy-glib/channel-contacts.c
@@ +435,4 @@
>      GAsyncReadyCallback callback,
>      gpointer user_data)
>  {
> +  ContactsQueueItem *item = g_slice_new (ContactsQueueItem);

I always prefer g_slice_new0() but I guess whatevs as you're assigning to all
values right away.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.