[Bug 48504] Add an example/test dialler

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=48504

--- Comment #9 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-04-11 09:31:10 PDT ---
Comment on attachment 59795
  --> https://bugs.freedesktop.org/attachment.cgi?id=59795
[5/5] dialler: use GtkApplication

Review of attachment 59795:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=48504&attachment=59795)
-----------------------------------------------------------------

Looks basically fine. Just two comments thought.

::: examples/client/python/dialler.py
@@ +50,5 @@
>          self.handlers = Gtk.ListStore(str, str)
>  
> +        self.window = None
> +
> +    def _activate_cb(self, data):

Hm, I didn't think you needed this but I can see now why you did it. Perhaps
this is a GLib bug given your NON_UNIQUE flag is there. Oh well.

@@ +59,2 @@
>          self.window = Gtk.Window()
> +        self.window.connect('delete-event', lambda *ignored: self.quit())

You don't need this. Gtk.Application.add_window means it'll listen to this
window and quit the app if there are no more windows.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.