[Bug 48363] Fatal warnings are breaking the build.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=48363

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-04-12 09:05:17 PDT ---
(In reply to comment #0)
> log of jhbuild break.

This...

(In reply to comment #4)
> remove leftover newline issue

... and this should already be fixed in git (0.18 and master).

(In reply to comment #3)
> The gobject-introspection fatal warnings are not disabled using
> --disable-Werror -- they are set from a separate variable in the
> introspection.am makefile called SCANNER_WARN_ERROR.

Yes, this is a bug. There should be a way to force them to be non-fatal, and
the only use of $(OFFICIAL_RELEASE) should be its original purpose (deciding
whether we require the lists of exported symbols to be complete, as they should
be in every ABI-stable release, but not necessarily in between).

The default is to have various fatal warnings in every version that isn't a
release tag - they get switched off during the release and switched back on
afterwards - but there should be an override available for those, in both
directions.

My suggestion is:

* for 0.18, where we won't add new API anyway: just make any future
  g-ir-scanner warnings never be fatal

* for master: add a --disable-fatal-warnings which switches off all the
  extras, and change jhbuild etc. to use that instead of --disable-Werror.
  This would include:

  * documentation completeness checks
  * coding style checks
  * default for --enable-Werror/--disable-Werror
  * default for g-ir-scanner --warn-error or not

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.