[Bug 23344] Provide API for Debug

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=23344

--- Comment #8 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-04-16 00:31:01 PDT ---
(In reply to comment #7)
> This all looks good except:
> 
> 1. the header comment of tests/dbus/debug-client.c is wrong.

Good catch; fixed.

> 2. I don't like how TpDebugMessage is a GObject. It feels far far too big for
> something which can be just a simple struct?

If for any reason user want to store the debug message (like Empathy which keep
it in a model) it will have to copy everything while here he can just ref the
object.

I generally don't like the "it's not worth an object approach". If it looks
like an object and would be one in any sane/decent/modern language it should
probably be an object.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.