[Bug 46783] [next] Fix FileTransfer ContentHash property

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46783

--- Comment #6 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-04-17 09:48:37 PDT ---
(In reply to comment #4)
> Maybe it would be worth supporting less dummy protocol where the file hash is
> sent *after* having sent the file and so saving the sender from reading the
> file twice on disk.
> 
> But I have no idea if any protocol supports this. Maybe jingle file transfer?

You're right about jingle file transfer.

    http://xmpp.org/extensions/xep-0234.html#hash

Given it's obviously nicer to send the hash afterwards so I'll have a think
about it for when we implement jingle FT (any day now!)

(In reply to comment #5)
> Looking at this again in the context of AccountChannelRequest helper API, it
> seems wrong that we have a (type, hash) pair. We're basically unable to tell
> clients which hash type can be used!
> 
> We might be better off with something more like this:
> 
> property ContentMD5 : s, read, request:sometimes, immutable
> property ContentSHA1 : s, read, request:sometimes, immutable
> property ContentSHA256 : s, read, request:sometimes, immutable

Why not a:

property AvailableContentHashTypes : au, read, immutable

Am I missing something here?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.