[Bug 30460] Generate client side API for Chan.T.ServerTLSConnection and TLSCertificate

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30460

--- Comment #13 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-04-19 07:15:32 UTC ---
(In reply to comment #9)
> (I realise I probably wrote a lot of the code I'm criticizing here. In my
> defence, it was over a year ago!)
> 
> +typedef struct {
> ...
> +    GHashTable *details;
> +} SignalledRejection;
> 
> Could this be a GVariant of type G_VARIANT_TYPE_VARDICT, converted from D-Bus
> with _tp_asv_to_vardict()?
> 
> (I would like new extensibility points to be GVariant-based if possible, so we
> don't have to keep adding parallel API.)

done.

> +void
> +tp_tls_certificate_add_rejection (TpTLSCertificate *self,
> +    TpTLSCertificateRejectReason reason,
> +    const gchar *dbus_error,
> +    GHashTable *details)
> 
> Again, details should be a GVariant of type G_VARIANT_TYPE_VARDICT, or NULL (to
> be treated as an empty dict). tp_account_update_parameters_vardict_async() has
> logic you can steal - it'd probably be worth adding a _tp_asv_from_vardict().

done.

> + * tp_tls_certificate_get_nth_rejection:
> 
> Perhaps we'd be better off returning a GList<TpTLSCertificateRejection> where
> TpTCR is a small object with accessors?
> 
> For g-i, it could have a method something like
> 
>     gboolean tp_tls_certificate_rejection_raise_error (TpTCR *, GError **);
> 
> which g-i bindings would turn into something usable like this:
> 
>     try:
>         tcr.raise_error()
>     except Exception, e:
>         # ...

Sounds like a good idea. I've done that.

The branch has been updated. I think I fixed all your comments except Comment
12.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.