[Bug 30422] Provide GVariant-based access to all a{sv} things

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Apr 23 14:07:31 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=30422

--- Comment #26 from Xavier Claessens <xclaesse at gmail.com> 2012-04-23 05:07:31 PDT ---
(In reply to comment #25)
> (In reply to comment #23)
> > > * tp_capabilities_get_channel_classes and ::channel-classes
> 
> What should tp_capabilities_get_channel_classes_vadict return exactly? AFAIK
> there is no GVariant equivalent of TP_STRUCT_TYPE_REQUESTABLE_CHANNEL_CLASS.

_vardict is wrong name here since it's not a dictionary.

It should return a GVariant with type a(a{sv}as)

You can create a GVariant for everything that goes over DBus, a(a{sv}as) is no
exception. I'm pretty sure you can do almost the same as _tp_asv_to_vardict()
but with TP_STRUCT_TYPE_REQUESTABLE_CHANNEL_CLASS as GType for the value.

> Should it return an array of TpChannelClass having accessors to get the fixed
> and allowed props?

I don't think we want to add higher level API to expose classes, we already
have the _supports_ methods. Also TpChannelClass is very bad name because
that's the GObjectClass for TpChannel already.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list