[Bug 30422] Provide GVariant-based access to all a{sv} things

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30422

--- Comment #37 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-04-25 05:33:09 PDT ---
Comment on attachment 60563
  --> https://bugs.freedesktop.org/attachment.cgi?id=60563
Add tp_capabilities_get_channel_classes_variant()

Review of attachment 60563:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=30422&attachment=60563)
-----------------------------------------------------------------

Looks generally OK.

::: telepathy-glib/capabilities.c
@@ +907,5 @@
> + *
> + * Since: UNRELEASED
> + */
> +GVariant *
> +tp_capabilities_get_channel_classes_variant (TpCapabilities *self)

I'd personally make this be a _dup_ function, since "copying" (reffing) a
GVariant is cheap, and it can't lead to weird side-effects since GVariants are
immutable anyway.

Note that if you don't make it _dup_, this method can never be implemented
without caching the value in the object.

If it remains a _get_ it should document how long the returned value is valid.
(I think the answer is "as long as the #TpCapabilities is", since
TpCapabilities are immutable?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.