[Bug 48780] add API to request channels without speaking fluent D-Bus

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=48780

--- Comment #21 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-04-25 07:30:58 PDT ---
(In reply to comment #16)
> 02/14] tp_account_channel_request_new_text,                
> tp_account_channel_request_set_target_contact, 
> tp_account_channel_request_set_target_id: add

> Didn't you just say you shouldn't use tp_asv_new here? This just gets duped and
> the value freed with g_free() no? Am I missing something here?

This is a little confusing but I think it's right.

request (local variable) has static keys, so it's OK to use tp_asv_new() (which
assumes immortal keys and sliced values).

It's deep-copied into priv->request, which, yes, must not use tp_asv_new(),
because we want to allow arbitrary (non-immortal) keys in priv->request.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.