[Bug 30338] TpRoomList - High level API for RoomList channel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30338

--- Comment #17 from Xavier Claessens <xclaesse at gmail.com> 2012-04-27 01:40:07 PDT ---
(In reply to comment #16)
> (In reply to comment #15)
> >  - I think it should "keep its state". I mean that if you miss signals, you
> > can't know the rooms listed, or the fail error... I would like a getter for
> > those 2.
> 
> How can you miss it? They won't be fired until _star() is called so you are
> supposed to connect the signals before.

Was suggesting this for completeness of the API, but not really important
indeed. And TpContactSearch does not do that neither. Ok forget me :)

> > simple-conn.c:
> > 
> >  - chan = g_hash_table_lookup (self->priv->channels, GUINT_TO_POINTER (0));
> > WTF using 0 as key?? is that really on purpose?
> 
> Yeah, room list channel has None as HandleType so no Handle either.

Hm, tbh I don't like this, it means it will fail badly if we add other channels
with handle==0 like MSN-like MUCs, etc... Also the comment in the priv struct
says /* TpHandle => reffed TpTestsTextChannelNull */ which is wrong now... tbh
I would keep a separate TpTestsRoomListChan* field in priv struct and maybe
rename channels to text_channels?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.