[Bug 49215] Move chat state to TpTextChannel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49215

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-04-27 08:24:50 PDT ---
Comment on attachment 60671
  --> https://bugs.freedesktop.org/attachment.cgi?id=60671
Move ChatState to TpTextChannel

Review of attachment 60671:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=49215&attachment=60671)
-----------------------------------------------------------------

::: telepathy-glib/automatic-client-factory.c
@@ +71,5 @@
>   *   </listitem>
>   *   <listitem>
> + *     <para>%TP_TEXT_CHANNEL_FEATURE_INCOMING_MESSAGES,
> + *     %TP_TEXT_CHANNEL_FEATURE_SMS and %TP_TEXT_CHANNEL_FEATURE_CHAT_STATES
> + *     for #TpTextChannel</para>

Should the automatic factory really prepare this by default? IMO, no - we don't
on ordinary TpChannels, after all.

It's easy to imagine a client that doesn't care about chat states (naming no
loggers in particular), and preparing this by default partially defeats the
purpose of having it as a separate Feature rather than just part of CORE.

SMS and Password are also questionable, tbh... in next I'm tempted to say this
shouldn't prepare them.

::: telepathy-glib/text-channel.c
@@ +860,5 @@
>  
> +  features[FEAT_CHAT_STATES].name =
> +    TP_TEXT_CHANNEL_FEATURE_CHAT_STATES;
> +  depends_chat_state[0] = TP_CHANNEL_FEATURE_CHAT_STATES;
> +  features[FEAT_CHAT_STATES].depends_on = depends_chat_state;

Nice trick.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.