[Bug 30422] Provide GVariant-based access to all a{sv} things

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30422

--- Comment #43 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2012-04-30 06:57:00 PDT ---
(In reply to comment #42)
> Minor fixes needed. (It would be great if you could valgrind the test to see
> whether I missed anything.)

done; I found and fixed an unrelated leak.

> ::: telepathy-glib/capabilities.c
> @@ +183,5 @@
> >      case PROP_CHANNEL_CLASSES:
> >        self->priv->classes = g_value_dup_boxed (value);
> > +      self->priv->classes_variant = _tp_boxed_to_variant (
> > +          TP_ARRAY_TYPE_REQUESTABLE_CHANNEL_CLASS_LIST, "a(a{sv}as)",
> > +          self->priv->classes);
> 
> You don't appear to free this in dispose/finalize?

oooops; fixed.

> @@ +901,5 @@
> > + * @self: a #TpCapabilities
> > + *
> > + * Return the #TpCapabilities:channel-classes-variant property
> > + *
> > + * Returns: (transfer full): the value of
> 
> the value of the

fixed.

> ::: tests/capabilities.c
> @@ +1006,5 @@
> > +      TP_PROP_CHANNEL_CHANNEL_TYPE, "&s", &chan_type));
> > +  g_assert_cmpstr (chan_type, ==, TP_IFACE_CHANNEL_TYPE_TEXT);
> > +
> > +  g_assert (g_variant_lookup (fixed,
> > +      TP_PROP_CHANNEL_TARGET_HANDLE_TYPE, "u", &handle_type));
> 
> A common GVariant trap: handle_type should be a guint32, not a TpHandleType
> (which we assume is the same size as a guint). guint is not necessarily 32-bit
> forever.

Humm that's nasty :\
Can't we do anything to fix this in next?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.