[Bug 49215] Move chat state to TpTextChannel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=49215

--- Comment #10 from Xavier Claessens <xclaesse at gmail.com> 2012-04-30 12:12:50 PDT ---
(In reply to comment #8)
> 
> > + g_hash_table_insert (mixin->priv->chat_states,
> > + GUINT_TO_POINTER (member),
> > + GUINT_TO_POINTER (state));
> 
> Please remove it if it's INACTIVE, like Gabble does, since that's "the default
> state". Have you tried porting Gabble 0.17 to this? I would rather not add this
> functionality without a proof-of-concept of a CM still passing its tests.
> 
> There should be a way for the CM to tell the mixin "this contact has gone away,
> remove them from your hash table". Otherwise, a chatroom will build up a big
> hash table over time: everyone who has ever been a member will be in the hash
> table (with chat state GONE, if the CM is not broken).
> 
> I think Gabble might actually treat both INACTIVE and GONE as "emit signal and
> remove from hash table", which seems reasonable.

Gabble does not implement the property, it does not keep the state.

> > + * TpMessageMixingSetChatStateImpl:
> ...
> > + * Signature of a virtual method which may be implemented to allow messages
> > + * to be sent. It must arrange for tp_message_mixin_sent() to be called when
> > + * the message has submitted or when message submission has failed.
> 
> This text does not describe this method.
> 
> Why would this method ever fail, other than InvalidArgument? (NetworkError, I
> suppose, and telepathy-spec also says NotAvailable, but I'm not entirely sure
> why).
> 
> If it fails, should this method fail synchronously or asynchronously?

I've made it like that to match gabble_message_util_send_chat_state()

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.