[Bug 50828] Remove Tubes code

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=50828

--- Comment #3 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-08-03 09:42:27 UTC ---
Okay I think I fixed everything in the gabble review. Also:

(In reply to comment #1)
> You can drop the TpDBusPropertiesMixinClass if you want (but you don't have to,
> obviously).

I didn't... sorry...

> -    # TODO: get rid of Tubes and this'll start making more sense
> -    return
> +#    yours, ensured_path, ensured_props = conn.Requests.EnsureChannel(
> +#            { CHANNEL_TYPE: CHANNEL_TYPE_STREAM_TUBE,
> +#              TARGET_HANDLE_TYPE: HT_ROOM,
> +#              TARGET_HANDLE: handle,
> +#              STREAM_TUBE_SERVICE: 'loldongs',
> +#              })
> 
> -    assert not yours
> -    assert ensured_path == path2, (ensured_path, path2)
> +#    assert not yours
> +#    assert ensured_path == tube_path, (ensured_path, tube_path2)
> 
> Does this end up getting removed?

No. I forgot to add a TODO before which I've now done. Perhaps I should fix the
TODO, or something; there's lots of other stuff to do though.

> Probably you intended to uncomment these?

I removed those tests as they're not really testing much, and are much more
annoying to implement in salut. Oh well..

Branch updated.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.