[Bug 54151] New: Flatten McdStorage into McdPluginAccountManager

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Aug 28 11:51:20 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=54151

             Bug #: 54151
           Summary: Flatten McdStorage into McdPluginAccountManager
    Classification: Unclassified
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: ASSIGNED
          Keywords: patch
          Severity: normal
          Priority: medium
         Component: mission-control
        AssignedTo: simon.mcvittie at collabora.co.uk
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org
                CC: jonny.lamb at collabora.co.uk,
                    simon.mcvittie at collabora.co.uk,
                    venkythegeek at gmail.com, william.jon.mccann at gmail.com,
                    xclaesse at gmail.com
            Blocks: 35896


+++ This bug was initially created as a clone of Bug #35896 +++

McdPluginAccountManager is a concrete class in MC. It implements the
McpAccountManager GInterface, which is the API presented by MC to account
storage plugins so they can call back into MC.

The reason Mcp... is a GInterface is to present a rather limited API to
plugins, so we're not prevented from making changes to the rest of MC's
internals.

McdPluginAccountManager also implements McdStorage, a GInterface used by the
rest of MC's internals. This is, as far as I can tell, pointless: it's the only
implementation of that interface, and every module that could access McdStorage
can equally well access McdPluginAccountManager directly.

I think we should flatten McdPluginAccountManager (class) and McdStorage
(interface) into a single class. To reduce the diff churn, its name should be
the name under which most of MC uses it, which is McdStorage.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list