[Bug 41772] TP Logger: Introduce TplEventWalker

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41772

--- Comment #21 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-08-29 13:04:24 UTC ---
(In reply to comment #20)
> Ah ok :) Maybe add some words in the walker doc explaining this then?

Yeah, an example at the top of this page would be cool.

There were some more discussions with people at GUADEC about this kind of thing
but I can't remember what we said, so, great... Regardless, I think this API is
fine and can be extended easily. Cool!

A couple of comments:

> gboolean            tpl_log_walker_is_begin             (TplLogWalker *walker);

_is_begin doesn't sound English to me? I'd say _is_beginning or _is_start
(better).

In fact, I'm really confused about the use of this API. It talks about
sequentially looking over logs, but then it can only be rewound, which feels
weird. Perhaps some function renaming would be ideal, but more explanation will
be thoroughly helpfully. I'd be happy with just some more docs tbh.

Nice work! I'm looking forward to making use of it!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.