[Bug 49473] Set TCP_NODELAY in tests

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Aug 30 22:46:36 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=49473

--- Comment #2 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-08-30 20:46:36 UTC ---
(In reply to comment #1)
> Either throw in some configure checks for setsockopt, IPPROTO_TCP and
> TCP_NODELAY, or approximate it by #ifdef G_OS_UNIX?

I did this. :-)

> (In reply to comment #0)
> > You could argue that this should only be enabled when it's not a release build.
> 
> I'd rather not have release builds test themselves differently. Perhaps you
> could make it controllable by an environment variable or its own --enable
> thing, and have Gabble use the default (i.e. not NODELAY) during distcheck?

Okay I made the default be not having NODELAY, but setting GABBLE_NODELAY will
enable it for a test. I even wrote about it in tests/README.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list