[Bug 45491] Show up <error><text> as status message for contacts with error presence

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45491

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-02-01 04:14:29 UTC ---
Comment on attachment 56438
  --> https://bugs.freedesktop.org/attachment.cgi?id=56438
Presence: show better error status messages.

Review of attachment 56438:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=45491&attachment=56438)
-----------------------------------------------------------------

r+

::: src/presence-cache.c
@@ +43,4 @@
>  #include <wocky/wocky-utils.h>
>  #include <wocky/wocky-namespaces.h>
>  #include <wocky/wocky-data-form.h>
> +#include <wocky/wocky-xmpp-error-enumtypes.h>

You know you wanted <wocky/wocky.h> to be a metaheader? I'm still in favour of
that :-)

::: tests/twisted/presence/error.py
@@ +63,5 @@
> +    type_, status, message = presences[hawk_handle]
> +    assertEquals(cs.PRESENCE_ERROR, type_)
> +    assertEquals('error', status)
> +    # FIXME: It might be less user-hostile to give some kind of readable
> +    # description of the error in future.

Certainly true, but without that fix this is still an improvement, so go for
it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.