[Bug 45554] various modules' GAsyncResults cannot safely be reffed and kept around

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Feb 2 18:32:31 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=45554

--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-02-02 09:32:31 PST ---
Created attachment 56547
  --> https://bugs.freedesktop.org/attachment.cgi?id=56547
[WiP 7/7] Channel contacts machinery: ref the queue item in the  result

Otherwise, if a caller kept a ref to the GAsyncResult after control had
returned to the channel, the channel could have freed the item and its
contents already.

---

Unfortunately, this one is in fact a refleak: the result and item ref each
other, circularly. We'll need to think about this one a bit more. One possible
implementation is to reverse the ownership, and turn the queue of
ContactsQueueItem into a list of GSimpleAsyncResult?

In the meantime, 1/7 to 6/7 can be merged, if reviewers are happy with them?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list