[Bug 45514] completes GAsyncResults in an insufficiently idle way

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45514

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |r+ when unblocked
           Keywords|                            |patch

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-02-02 09:41:42 PST ---
(In reply to comment #0)
> Unfortunately, the patch fails tests, because TpAccount makes broken
> assumptions about the lifetimes of data and async results.

Now fixed, Bug #45554. This patch applies cleanly after the branch from Bug
#45554 is merged into master, and passes tests; so I'll consider it pre-r+
(thanks for reviewing, btw) unless you object.

I'll revert it on next, after I've made D-Bus calls, contact inspection etc.
actually always idle when necessary.

(In reply to comment #1)
> In general, this patch makes me very unhappy indeed. Completing an
> async result in an idle when it's always necessary makes debugging a pain.

Assuming you mean "when it's not always necessary": agreed, but it's a
necessary evil...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.