[Bug 45554] various modules' GAsyncResults cannot safely be reffed and kept around

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Feb 2 19:12:12 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=45554

--- Comment #8 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-02-02 10:12:12 PST ---
Comment on attachment 56545
  --> https://bugs.freedesktop.org/attachment.cgi?id=56545
[5/7] tp_account_update_parameters_async: fix lifetime of  result, and test it

Review of attachment 56545:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=45554&attachment=56545)
-----------------------------------------------------------------

::: tests/dbus/account.c
@@ +262,5 @@
> +  const gchar *unset[] = { "unset", NULL };
> +  GStrv reconnect_required;
> +
> +  test->account = tp_account_new (test->dbus,
> +      "/org/freedesktop/Telepathy/Account/what/ev/er", NULL);

Please use TP_ACCOUNT_OBJECT_PATH_BASE here so merging this stuff into next is
easier.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list