[Bug 45755] New: Inconsistent ordering of pendingMessageRemoved

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Feb 8 01:19:39 CET 2012


             Bug #: 45755
           Summary: Inconsistent ordering of pendingMessageRemoved
    Classification: Unclassified
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-qt
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: kde at davidedmundson.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org

Assuming we have one message in the messageQueue

If we call forget() TpQt emits pendingMessagesRemoved after it deletes it from
the queue, so messageQueue.size() is 0.

If we call acknowledge and removed in another client TpQt emits
pendingMessagesRemoved before it deletes it from the queue, so
messageQueue.size() is 1. (in  TextChannel::Private::processMessageQueue())

>From a personal POV it makes a lot more sense to me to delete it from the
message queue first, in all my use cases of this signal it's used to update any
notification of unread messages, on receipt of this signal I end up call
messageQueue.size() which gives me +1 of what the message size will be by the
time this signal finishes.

Given the signal is called pendingMessageRemoved (emphasis on it being a past
tense) I would have expected the removal to have already taken place.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list