[Bug 32125] Should support auth using captcha

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32125

--- Comment #22 from Andre Moreira Magalhaes <andrunko at gmail.com> 2012-02-08 11:46:23 PST ---
(In reply to comment #21)
> Created attachment 56744 [details] [review]
> Patch for PropertiesChanged on tp-qt
> 
> Attached comes a patch to tp-qt to support PropertiesChanged. Thiago, Simon,
> can you please have a look? It's trivial, but would appreciate your ack.

Ok, some comments about the patch:

If I understood correctly (please correct me if I am wrong) PropertiesChanged
is not interface specific, so adding it to AbstractInterface would mean that we
would need to filter for interface name before emitting
AbstractInterface::propertiesChanged. It also means we would need to connect to
the same signal multiple times without any need if we want to handle
propertiesChanged in multiple interfaces.

The other possible place we could put this is directly into Tp::DBusProxy. 

I see 2 problems with that:
- Tp::DBusProxy would gain a (public) signal emitting D-Bus PropertiesChanged
directly. DBusProxy is inherited by most all high-level class that should not
expose D-Bus specific data directly to the user. The main use case for this
signal is internal, where we want to handle the property changed signal and act
accordingly, not for users of our high-level classes.
- Tp::DBusProxy inherits Tp::Object that has a notify/propertyChanged mechanism
(for Qt properties). So if adding to DBusProxy, we should probably name it
something like dbusPropertiesChanged instead of propertiesChanged.

Another possible solution that I prefer would be to have a separate object (I
would name it DBusPropertiesInterface) and add a protected accessor in
DBusProxy to retrieve this object.
DBusPropertiesInterface would have the methods like in this patch. It would
take a DBusProxy in the constructor and connect to the signal if
monitorConnections is set to true, relaying it to the user as
propertiesChanged.

What do you think?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.