[Bug 32125] Should support auth using captcha

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Feb 9 11:05:15 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=32125

--- Comment #27 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2012-02-09 02:05:15 PST ---
(In reply to comment #24)
> Looks like I missed possible-errors for GetCaptchaData. I was thinking
> NotAvailable when not in LocalPending or if GetCaptchas wasn't called and
> therefore the handler has no ID, InvalidArgument if the ID doesn't match any
> returned by the latest call to GetCaptchas, but I'm not certain what would be
> best for if the Handler's list of MIME types doesn't contain one the CM has.
> Would it be CaptchaNotSupported? Would it instead be better to list the
> possible MIME types in GetCaptchas as suggested above?

In the API described in Comment #3, I'd intended for the CM to return an
arbitrary MIME type of its choice if there was no intersection at all between
the MIME types the Handler prefers, and the MIME types the CM has. (Rationale:
it might as well return *something*, the Handler is going to fail anyway.)
CaptchaNotSupported would also be reasonable, though.

If the API changes to what's described in Comment #26 (which it probably
should), then the Handler is expected to know what's available (because you
just told it), so the error could be InvalidArgument - in this API it doesn't
matter that the Handler can't distinguish which argument was invalid, because a
correct Handler wouldn't get it wrong, and if it does, it's a programming error
rather than something the user can solve.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list