[Bug 45716] salut plugin api needs to be split out and refactored similar to the changes done to gabble

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45716

--- Comment #4 from Olli Salli <olli.salli at collabora.co.uk> 2012-02-11 11:17:41 PST ---
(In reply to comment #3)
> >  salut_plugin_create_channel_managers (SalutPlugin *plugin,
> > +    SalutPluginConnection *plugin_connection,
> >      TpBaseConnection *connection)
> > 
> > create_channel_managers didn't receive the SalutConnection before, just a base TpBaseConnection. Why does it now receive the plugin connection instance, and in
> > fact still also the TpBaseConnection?
> > 
> > If some plugin actually requires the SalutPluginConnection, I think we should rather pass just it, and have a salut_plugin_connection_get_base_connection
> > function to give the other one. (To avoid the fixing that the object implementing SalutPluginConnection is also the TpBaseConnection subclass).
> 
> I did that mostly since we have the same API in gabble so currently in cases like ytstenut plugin we have one method which works for both. So should I go back
> to 
> the way it was ?
> 

Oh, slipped my eye in Gabble. It's equally slightly weird there. Consistency with Gabble however is a sensible goal, so please keep it the way you did it, not
much harm done.

What about the other points?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.