[Bug 37381] client-types.py appears to have a race

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Feb 13 19:43:34 CET 2012


--- Comment #5 from Alban Crequy <alban.crequy at collabora.co.uk> 2012-02-13 10:43:34 PST ---
Created attachment 56982
  --> https://bugs.freedesktop.org/attachment.cgi?id=56982

(In reply to comment #4)

> The other patch I don't like at all. Making the conditional even more giant
> seems like loss, adding an arbitrary 2-second window to our source code for
> the benefit of a test even more so.

I can remove the 2-second window.

But I don't like the current conditional because there is no proper priority between the resources and it is dependent on the order of the resources in the
linked list.

As an example, the attached test/scenario will pass but I think it should not pass. It adds 10 resources online, and the client type will alternate between
'pc' and 'phone' while the resources are added. And removing one pc will make the client type change from 'pc' to 'phone' although there is still several pcs

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list