[Bug 44939] Regression in salut/p2p mode

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Feb 21 12:04:24 CET 2012


--- Comment #8 from Will Thompson <will.thompson at collabora.co.uk> 2012-02-21 03:04:24 PST ---
Created attachment 57382
  --> https://bugs.freedesktop.org/attachment.cgi?id=57382
Account: don't crash on Get('Parameters') if _dup_parameters fails

If the connection manager is not installed, or is installed but doesn't
have the protocol for the account, then _mcd_account_dup_parameters()
returns %NULL. (As the comment I've added says, I think this is
ridiculous—it's fall-out from MC not storing the types of parameters.)

As a result, Get('Parameters') or GetAll() would crash, because
dbus-glib would try to serialize a NULL GHashTable and blow up. (See
<https://bugs.freedesktop.org/show_bug.cgi?id=44939>.) So with this
patch, we handle NULL as "no parameters" for the sake of D-Bus
properties. (Because this situation should only arise if the account is
invalid, we also warn if _dup_parameters() returns NULL for valid

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list