[Bug 46385] New: suspicious error mappings in Call

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46385

             Bug #: 46385
           Summary: suspicious error mappings in Call
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: gabble
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org
                CC: olivier.crete at ocrete.ca


Some of the code to map Jingle reasons to Tp errors seems rather suspicious:

> + case JINGLE_REASON_GONE:
> + /* This one is only in the media channel, we don't have a
> + * Call reason to match */
> + call_reason = TP_CALL_STATE_CHANGE_REASON_UNKNOWN;
> + break;

Doesn't that mean we should add a Call reason, or at least a detailed D-Bus
error string?

> + case JINGLE_REASON_EXPIRED:
> + /* No matching error in our spec */
> + call_reason = TP_CALL_STATE_CHANGE_REASON_UNKNOWN;
> + break;

Ditto

> + case JINGLE_REASON_GENERAL_ERROR:
> + call_reason = TP_CALL_STATE_CHANGE_REASON_SERVICE_ERROR;
> + break;

Is this really the right mapping?

> + case JINGLE_REASON_UNSUPPORTED_TRANSPORTS:
> + call_reason = TP_CALL_STATE_CHANGE_REASON_NETWORK_ERROR;
> + break;

Ditto

> + case JINGLE_REASON_SECURITY_ERROR:
> + call_reason = TP_CALL_STATE_CHANGE_REASON_CONNECTIVITY_ERROR;
> + break;

Ditto

> + case JINGLE_REASON_ALTERNATIVE_SESSION:
> + break;

Is Unknown really the best we can do here?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.