[Bug 46387] New: tidy up Call implementation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46387

             Bug #: 46387
           Summary: tidy up Call implementation
    Classification: Unclassified
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: gabble
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


There are various FIXME comments in the Call implementation which need looking
at by someone who understands this stuff:

+ /* FIXME: no idea... */
+ md = tp_call_content_media_description_new (
+ tp_base_connection_get_dbus_daemon (conn), path, handle,
+ (content != NULL), (content == NULL));

+ tp_call_content_media_description_append_codec (md,
+ c->id, c->name, c->clockrate, c->channels,
+ FALSE, /* FIXME: updated?? */
+ c->params);

+ /* FIXME: We have to handle cases where the new codecs are rejected */
+ tp_base_media_call_content_offer_media_description_async (
+ TP_BASE_MEDIA_CALL_CONTENT (self), md, NULL, NULL);

+ /* FIXME: correct??? */
+ contact = gabble_call_member_get_handle (
+ gabble_call_member_content_get_member (mcontent));
+ tp_md = tp_base_media_call_content_get_local_media_description (
+ TP_BASE_MEDIA_CALL_CONTENT (self), contact);
+ if (tp_md != NULL)
+ {
+ md->codecs = codec_array_to_list (tp_asv_get_boxed (tp_md,
+ TP_PROP_CALL_CONTENT_MEDIA_DESCRIPTION_CODECS,
+ TP_ARRAY_TYPE_CODEC_LIST));

+ /* FIXME: remote_contact==0 ??? */
+ tp_md = tp_base_media_call_content_get_local_media_description (content,
+ 0);
+ codecs = tp_asv_get_boxed (tp_md,
+ TP_PROP_CALL_CONTENT_MEDIA_DESCRIPTION_CODECS,
+ TP_ARRAY_TYPE_CODEC_LIST);

+ /* FIXME: remote_contact==0 ??? */
+ tp_md = tp_base_media_call_content_get_local_media_description (
+ TP_BASE_MEDIA_CALL_CONTENT (content), 0);
+ codecs = tp_asv_get_boxed (tp_md,
+ TP_PROP_CALL_CONTENT_MEDIA_DESCRIPTION_CODECS,
+ TP_ARRAY_TYPE_CODEC_LIST);

+ /* FIXME: ice??? */
+ endpoint = tp_call_stream_endpoint_new (bus, path, type, FALSE);

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.