[Bug 46345] tp-salut does not build on windows/mingw32

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=46345

--- Comment #2 from Olli Salli <olli.salli at collabora.co.uk> 2012-02-21 04:42:17 PST ---
> #ifdef G_OS_WIN32
> typedef uint32_t u_int32_t;
> typedef uint16_t u_int16_t;
> #endif

uint32_t and uint16_t come from stdint.h, which you don't explicitly include,
and which is a C99 header not supported by all Windows compilers anyway. Please
rather change the code to use guint32 and guint16 and let GLib worry about
defining them.

Otherwise the Gibber fixes look OK.

Leaving FT out is OK for now but eventually we need to fix bug 18530 and
include it in the Windows port.

> +AM_CONDITIONAL(USE_BACKEND_DNS_SD, [test "x$with_backend" = "xlibdns_sd"])

This backend doesn't exist yet. So don't add build system foo for it here
please.

> +    AC_HELP_STRING([--with-backend=[dummy/avahi/libdns_sd]],

Typically --with args are used in configure for when you want to do
--with-some-dependency-lib --without-some-dependency-lib . 

Thus, I'd make this --zeroconf-backend=dummy/avahi for now.

> +if test x$with_backend = xavahi; then
> PKG_CHECK_MODULES(AVAHI, [avahi-gobject, avahi-client])

Indent stuff that now has become the body of an `if` branch, please. (This is
not the only occurrence).

Generally, the build system should have a consistent coding style as well.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.