[Bug 46345] tp-salut does not build on windows/mingw32

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Feb 22 20:31:08 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=46345

Olli Salli <olli.salli at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
  Status Whiteboard|                            |review+
         Resolution|                            |FIXED

--- Comment #5 from Olli Salli <olli.salli at collabora.co.uk> 2012-02-22 11:31:08 PST ---
as caught by check-coding-style, all the casts like:

> +  ret = setsockopt (fd, SOL_SOCKET, SO_REUSEADDR, (char *)&yes, sizeof (int));

are wrong. In Telepathy coding style, there is a space between "(type)" and
what_to_cast.

So:

CORRECT:
(char *) &yes

INCORRECT:
(char *)&yes

I fixed these and merged. Please try to keep in mind from now on.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list